Skip to content

[SDK] Emit accountChanged event when smart wallets switch chains #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

[SDK] Emit accountChanged event when smart wallets switch chains #6626

merged 1 commit into from
Apr 3, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 2, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on modifying the event emissions in the smart-wallet.ts file to emit an accountChanged event when smart wallets switch chains, enhancing the event handling for account and chain changes.

Detailed summary

  • In packages/thirdweb/src/wallets/smart/smart-wallet.ts:
    • Changed the event emission from chainChanged to accountChanged for connectedAccount.
    • Retained the chainChanged emission for connectedChain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 6:30pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 6:30pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 6:30pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 6:30pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 6:30pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 1cb29e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 2, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Apr 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 2, 2025 18:22
@joaquim-verges joaquim-verges requested review from a team as code owners April 2, 2025 18:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 169 ms (+163.53% 🔺) 1.2 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 238 ms (+44.96% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 92 ms (+2191.32% 🔺) 204 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 39 ms (+2451.12% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (+0.03% 🔺) 387 ms (+0.03% 🔺) 128 ms (+1024.25% 🔺) 515 ms

@codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (4847ada) to head (1cb29e4).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6626   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files         887      887           
  Lines       55652    55653    +1     
  Branches     3798     3798           
=======================================
+ Hits        30591    30592    +1     
  Misses      24966    24966           
  Partials       95       95
Flag Coverage Δ
packages 54.96% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts 81.81% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 3f21445 into main Apr 3, 2025
35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Emit_accountChanged_event_when_smart_wallets_switch_chains branch April 3, 2025 01:19
@joaquim-verges joaquim-verges mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges